feat: Add DnsJavaResolver and related test#2193
Merged
Conversation
panavenue
force-pushed
the
feat-add-dnsjava
branch
4 times, most recently
from
0aa3fa7 to
9625a31
Compare
panavenue
force-pushed
the
feat-add-dnsjava
branch
from
9625a31 to
e11faa8
Compare
hessjcg
reviewed
Aug 22, 2025
Collaborator
hessjcg
left a comment
hessjcg
left a comment
There was a problem hiding this comment.
Nice work. A few small comments.
hessjcg
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR Adds the following:
DnsJavaResolver. Which will be use to replaceJndiDnsResolverfor DNS record lookup.Next:
Will replace and remove
JndiDnsResolverwithDnsJavaResolverin the next PR.